We've had this since 2021 and I didn't know about it.

We have this since 2021 and I didn't know about it.

"This" being --source-stats? If so, maybe it should be on by default?

That's what I wanted to ask (and the reason I looked at git blame).

I mean, I think we should have this on by default. I'll do that right now, one second.

How hard would it be to format 12345678 as 12_345_678? That makes it much easier to quickly see whether the amount is in the tens of thousands, hundreds of thousands or in the millions.

How hard would it be to format 12345678 as 12_345_678? That makes it much easier to quickly see whether the amount is in the tens of thousands, hundreds of thousands or in the millions.

A little fiddly if we don't want to take any dependencies. If we do take a dependency, a whole bunch of localization stuff is also (necessarily, IMO) pulled in.

How hard would it be to format 12345678 as 12_345_678? That makes it much easier to quickly see whether the amount is in the tens of thousands, hundreds of thousands or in the millions.

A little fiddly if we don't want to take any dependencies. If we do take a dependency, a whole bunch of localization stuff is also (necessarily, IMO) pulled in.

Wasn't too bad; just had to remember some interview questions.

I updated this PR to print additional statistics about the number of traits, macro calls, and impls in both dependencies and the workspace under "Source Stats". The formatting feels a little iffy:

Database loaded:     1.62s, 95mb (metadata 550.95ms, 2520kb; build 395.83ms, -218kb)
  item trees: 206
Source stats:
  dependency lines of code: 1_961_884, item trees: 3_792
  dependency item stats: traits: 1_170, impl: 17_525, mods: 4_234, macro calls: 7_454, macro rules: 1_708
  workspace lines of code: 23_727, item trees: 206
  workspace stats: traits: 47, impl: 334, mods: 145, macro calls: 31, macro rules: 20
Item Tree Collection (workspace): 3.23s, 703mb
  crates: 89, mods: 231, decls: 5011, bodies: 4026, adts: 687, consts: 472,
  traits: 183, macro_rules macros: 14, proc_macros: 7
Item Collection:     2.79s, 555mb
Body lowering:       610.26ms, 166mb
  exprs: 82131, ??ty: 111 (0%), ?ty: 98 (0%), !ty: 1
  pats: 16987, ??ty: 32 (0%), ?ty: 2 (0%), !ty: 0
Inference:           4.58s, 358mb
MIR lowering:        1.39s, 114mb
Mir failed bodies: 20 (0%)
Data layouts:        15.90ms, 5mb
Failed data layouts: 2 (0%)
Const evaluation:    7.79ms, 1698kb
Failed const evals: 0 (0%)
Total:               12.63s, 1905mb

Any suggestions for improvements?

That logs the workspace item trees twice, it also logs some workspace stats twice now which disagree with each other 😅

The numbers under Source stats are the usages of macros, traits, and implementations in the workspace and dependencies, whereas the numbers under Item Tree Collection (workspace) are the declarations.

I'll redo how the output is rendered by creating dedicated "usages" and declarations" sections. I probably shouldn't be too attached to the output styling of analysis-stats!

Updated the printing of analysis-stats to distinguish between totals, workspace, and dependencies in the PR description. If there are no objections, I'd like to get this landed.